new format for "package name already defined" error (+tests) #3437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Nov 3, 2017
|
@smarter scalac does not emit an error here. Is the difference intended? |
AurelienRichez
force-pushed
the
floss-spree-scala-io/package-name-already-defined
branch
from
7ea27f1 to
95fcac1
Compare
allanrenucci
suggested changes
Nov 14, 2017
| implicit val ctx: Context = ictx | ||
|
|
||
| assertMessageCount(1, messages) | ||
| assert(messages.head.isInstanceOf[PackageNameAlreadyDefined]) |
There was a problem hiding this comment.
Prefer:
val PackageNameAlreadyDefined(pkg) = messages.head
assertEquals(pkg.show, "object bar")|
|
||
| override def msg: String = hl"${pkg} is already defined, cannot be a package" | ||
| override def kind: String = "Syntax" | ||
| override def explanation: String = |
There was a problem hiding this comment.
The override keyword as well as the type ascription are a bit verbose. I would remove them
| override def msg: String = hl"${pkg} is already defined, cannot be a package" | ||
| override def kind: String = "Syntax" | ||
| override def explanation: String = | ||
| "An object cannot have the same name as an existing package. Rename ${pkg} or the package with the same name." |
There was a problem hiding this comment.
You can use hl interpolator for syntax highlighting:
hl"An ${"object"} cannot have the same name as an existing ${"package"}. Rename either one of them."|
|
||
| case class PackageNameAlreadyDefined(pkg: Symbol)(implicit ctx: Context) extends Message(PackageNameAlreadyDefinedID) { | ||
|
|
||
| override def msg: String = hl"${pkg} is already defined, cannot be a package" |
There was a problem hiding this comment.
You can syntax highlight package in this sentence:
hl"${pkg} is already defined, cannot be a ${"package"}"
AurelienRichez
force-pushed
the
floss-spree-scala-io/package-name-already-defined
branch
from
95fcac1 to
8d8baba
Compare
|
Thanks for your review ! I rebased my branch and applied the modifications. |
AurelienRichez
force-pushed
the
floss-spree-scala-io/package-name-already-defined
branch
from
8d8baba to
a74feb6
Compare
allanrenucci
approved these changes
Nov 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR from Scala.io 2017 FLOSS spree in Lyon.
For #1589 :
This PR creates a new format of error messages for
Typer.scala:1519. The newMessageclass isPackageNameAlreadyDefined.